netdev - Re: [PATCH net-next v1] macsec: fix validation failed in asynchronous operation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170220.095554.369235627490818017.davem@davemloft.net>
Date:   Mon, 20 Feb 2017 09:55:54 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ryder.lee@...iatek.com
Cc:     sd@...asysnail.net, netdev@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next v1] macsec: fix validation failed in
 asynchronous operation.

From: Ryder Lee <ryder.lee@...iatek.com>
Date: Mon, 20 Feb 2017 18:32:30 +0800

> @@ -879,6 +879,9 @@ static void macsec_decrypt_done(struct crypto_async_request *base, int err)
>  
>  	aead_request_free(macsec_skb_cb(skb)->req);
>  
> +	if (err == 0)
> +	 macsec_skb_cb(skb)->valid = true;
> +

This is not indented properly, please use TABs like the rest of
the code does.  And the canonical way to test against zero is
"if (!err)"