netdev - Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170220.103912.194197218422769191.davem@davemloft.net>
Date:   Mon, 20 Feb 2017 10:39:12 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sowmini.varadhan@...cle.com
Cc:     santosh.shilimkar@...cle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net-next][PATCH] RDS: keep data type consistent in the user
 visible header

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Mon, 20 Feb 2017 10:37:22 -0500

> On (02/20/17 10:19), David Miller wrote:
>> 
>> The correct fix it to use "__u8", "__u64", etc.
> 
> So the rest of rds.h uses uint8_t, uint32_t etc 
> Perhaps (I'm not sure of the origins) this was because
> of the shared OpenIB.org BSD license etc using __u8 in
> one place and uint8_t in another would seem inconsistent,
> at the very least.

The entire file should use the proper "__uX" kernel types
rather than the uint* ones.