netdev - Re: [PATCH net-next] net: mpls: Add support for netconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43594433-2c08-6700-9687-06d2d05caeed@brocade.com>
Date:   Mon, 20 Feb 2017 15:53:27 +0000
From:   Robert Shearman <rshearma@...cade.com>
To:     David Ahern <dsa@...ulusnetworks.com>, <netdev@...r.kernel.org>
CC:     <roopa@...ulusnetworks.com>, <ebiederm@...ssion.com>,
        <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH net-next] net: mpls: Add support for netconf



On 20/02/17 14:53, David Ahern wrote:
> On 2/20/17 3:01 AM, Robert Shearman wrote:
>> On 18/02/17 01:36, David Ahern wrote:
>>> Add netconf support to MPLS. Allows userpsace to learn and be notified
>>> of changes to 'input' enable setting per interface.
>>>
>>> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
>>> ---
>>>  include/uapi/linux/netconf.h   |   1 +
>>>  include/uapi/linux/rtnetlink.h |   2 +
>>>  net/mpls/af_mpls.c             | 212
>>> ++++++++++++++++++++++++++++++++++++++++-
>>>  net/mpls/internal.h            |   2 +-
>>>  4 files changed, 214 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/include/uapi/linux/netconf.h b/include/uapi/linux/netconf.h
>>> index 45dfad509c4d..159d91c9c2a3 100644
>>> --- a/include/uapi/linux/netconf.h
>>> +++ b/include/uapi/linux/netconf.h
>>> @@ -16,6 +16,7 @@ enum {
>>>      NETCONFA_MC_FORWARDING,
>>>      NETCONFA_PROXY_NEIGH,
>>>      NETCONFA_IGNORE_ROUTES_WITH_LINKDOWN,
>>> +    NETCONFA_MPLS_INPUT_ENABLED,
>>
>> How about removing "MPLS_" the name? That way it would be usable by
>> other AFs too, e.g. for the disable_ipv6 sysctl. Perhaps "ENABLED" is
>> redundant as well.
>
>
> I could drop the MPLS to NETCONFA_INPUT_ENABLED; just NETCONFA_INPUT is
> not very descriptive.
>
> disable_ipv6 has a completely different meaning, so re-use there does
> not seem appropriate.

That's a fair point - disable_ipv6 does more than just disabling the 
input of IPv6 packets. However, the point still stands in the general 
sense - why tie the attribute name to an AF if it's not necessary?

Thanks,
Rob

> Thanks for the review.
>