netdev - Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPv3WKekgKBNmmc0DhcFy5DW=5nmuFjmcAsAh45dhhnCEk4bLw@mail.gmail.com>
Date:   Tue, 21 Feb 2017 17:35:20 +0100
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Jisheng Zhang <jszhang@...vell.com>
Cc:     David Miller <davem@...emloft.net>,
        Gregory Clément 
        <gregory.clement@...e-electrons.com>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Jisheng,

2017-02-21 17:16 GMT+01:00 David Miller <davem@...emloft.net>:
> From: Jisheng Zhang <jszhang@...vell.com>
> Date: Tue, 21 Feb 2017 12:37:40 +0800
>
>> Thanks for your review.
>>
>> The measurement is simple: record how much time we spent in mvneta_rx_swbm()
>> for receiving 1GB data, something as below:
>
> Please use a standard tool for measuring performance, rather than profiling
> the driver and trying to derive numbers that way.

If possible in your setup, I suggest pushing 64B (and other sizes)
packets uni or bidirectionally via 2 ports in L2 bridge mode. It's a
good stress test, you'd get some meaningful numbers (also check cpu
consumption with mpstat in the meantime).

Best regards,
Marcin