netdev - Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJLCe1O7Bv526zAY-s-R1DcnA2O0bpx48dTFGSgeu-Edw@mail.gmail.com>
Date:   Tue, 21 Feb 2017 10:42:38 -0600
From:   Rob Herring <robh@...nel.org>
To:     Raju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
Cc:     netdev <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Allan.Nielsen@...rosemi.com, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

On Thu, Feb 16, 2017 at 3:06 AM, Raju Lakkaraju
<Raju.Lakkaraju@...rosemi.com> wrote:
> Hi Rob,
>
> On Wed, Feb 15, 2017 at 10:45:40AM -0600, Rob Herring wrote:
>> EXTERNAL EMAIL
>>
>>
>> On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote:
>> > From: Raju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
>> >
>> > +                       Default value is VSC8531_LINK_1000_ACTIVITY (1).
>> > +- vsc8531,led-1-mode : LED mode. Specify how the LED[1] should behave.
>>
>> You failed to address my comment on v2. vsc8531 is not a vendor prefix.
>> Please fix in a new patch since David already applied it.
>>
>
> Accpeted my fault. i missed your comment.
> Do i need to change from  "vsc8531, led-0-mode" to "mscc, led-0-mode"
> Is this your suggestion?

Well, there shouldn't be a space there, but yess, mscc is the prefix.

Read my original comments. I also suggested combining this to a single property.

Rob