netdev - Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Feb 2017 11:35:17 +0530
From:   Raju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
To:     Rob Herring <robh@...nel.org>
CC:     netdev <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        <Allan.Nielsen@...rosemi.com>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi
 PHYs.

Hi Rob,

Thank you for code review comments.

On Tue, Feb 21, 2017 at 10:42:38AM -0600, Rob Herring wrote:
> EXTERNAL EMAIL
> 
> 
> > Do i need to change from  "vsc8531, led-0-mode" to "mscc, led-0-mode"
> > Is this your suggestion?
> 
> Well, there shouldn't be a space there, but yess, mscc is the prefix.
> 
> Read my original comments. I also suggested combining this to a single property.
> 

Accepted your comment.
Fix the combining into single property and change prefix to mscc.
I sent the latest code for review. Please review and send your comments.

> Rob

---
Thanks,
Raju