netdev - Re: [PATCH net-next 2/2] netfilter: nf_ct_expect: Change __nf_ct_expect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPWQB7Go9Y1d_GkQB4z5H9acZn1UFX1CHNJDF+n1REaXp-mrMg@mail.gmail.com>
Date:   Tue, 21 Feb 2017 15:45:25 -0800
From:   Joe Stringer <joe@....org>
To:     Jarno Rajahalme <jarno@....org>
Cc:     netdev <netdev@...r.kernel.org>, fgao@...ai8.com,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH net-next 2/2] netfilter: nf_ct_expect: Change
 __nf_ct_expect_check() return value.

On 21 February 2017 at 15:25, Jarno Rajahalme <jarno@....org> wrote:
> Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert()
> returns void") inadvertently changed the successful return value of
> nf_ct_expect_related_report() from 0 to 1 due to
> __nf_ct_expect_check() returning 1 on success.  Prevent this
> regression in the future by changing the return value of
> __nf_ct_expect_check() to 0 on success.
>
> Signed-off-by: Jarno Rajahalme <jarno@....org>
> ---

It seems like other functions in this file return 0 as successful
condition, so from that perspective this seems more in line with
existing code.

Acked-by: Joe Stringer <joe@....org>