netdev - Re: [PATCH net-next 1/2] netfilter: nf_ct_expect: nf_ct_expect_related

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPWQB7E=TNYPsFYNgyCanCi3M9-=KbpsbDeKCFrWFBYdQF5Ubw@mail.gmail.com>
Date:   Tue, 21 Feb 2017 15:41:22 -0800
From:   Joe Stringer <joe@....org>
To:     Jarno Rajahalme <jarno@....org>
Cc:     netdev <netdev@...r.kernel.org>, fgao@...ai8.com,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH net-next 1/2] netfilter: nf_ct_expect: nf_ct_expect_related_report():
 Return zero on success,

On 21 February 2017 at 15:25, Jarno Rajahalme <jarno@....org> wrote:
> Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert()
> returns void") inadvertently changed the successful return value of
> nf_ct_expect_related_report() from 0 to 1, which caused openvswitch
> conntrack integration fail in FTP test cases.

I can't tell at a glance given all the netlink callback stuff but I
suspect this broke expectation insertion from netlink too.

> Fix this by always returning zero on the success code path.
>
> Fixes: 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void")
> Signed-off-by: Jarno Rajahalme <jarno@....org>

Acked-by: Joe Stringer <joe@....org>