netdev - Re: [PATCH net-next 2/2] netfilter: nf_ct_expect: Change __nf_ct_expect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2017 10:47:44 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Jarno Rajahalme <jarno@....org>
Cc:     netdev@...r.kernel.org, fgao@...ai8.com
Subject: Re: [PATCH net-next 2/2] netfilter: nf_ct_expect: Change
 __nf_ct_expect_check() return value.

On Tue, Feb 21, 2017 at 03:25:22PM -0800, Jarno Rajahalme wrote:
> Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert()
> returns void") inadvertently changed the successful return value of
> nf_ct_expect_related_report() from 0 to 1 due to
> __nf_ct_expect_check() returning 1 on success.  Prevent this
> regression in the future by changing the return value of
> __nf_ct_expect_check() to 0 on success.

Same thing, please Cc netfilter-devel. Thanks.