netdev - Re: [PATCH net-next 1/2] netfilter: nf_ct_expect: nf_ct_expect_related

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5e71d84-1d3e-b2c9-30fe-2dcabdfbea88@cogentembedded.com>
Date:   Wed, 22 Feb 2017 13:00:50 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jarno Rajahalme <jarno@....org>, netdev@...r.kernel.org
Cc:     fgao@...ai8.com, pablo@...filter.org
Subject: Re: [PATCH net-next 1/2] netfilter: nf_ct_expect:
 nf_ct_expect_related_report(): Return zero on success,

Hello!

On 2/22/2017 2:25 AM, Jarno Rajahalme wrote:

> Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert()

    Need at least 12 hex digits.

> returns void") inadvertently changed the successful return value of
> nf_ct_expect_related_report() from 0 to 1, which caused openvswitch
> conntrack integration fail in FTP test cases.
>
> Fix this by always returning zero on the success code path.
>
> Fixes: 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void")
> Signed-off-by: Jarno Rajahalme <jarno@....org>
[...]

MBR, Sergei