netdev - Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2adadc3d-8a23-cb40-3232-bea9a7555363@oracle.com>
Date:   Thu, 23 Feb 2017 08:35:17 -0800
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com
Subject: Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings

On 2/23/2017 4:47 AM, kbuild test robot wrote:
> net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
>
>  NULL check before some freeing functions is not needed.
>
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
>
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>