netdev - Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170224.111152.713364995055339756.davem@davemloft.net>
Date:   Fri, 24 Feb 2017 11:11:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     fengguang.wu@...el.com
Cc:     santosh.shilimkar@...cle.com, kbuild-all@...org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, rds-devel@....oracle.com
Subject: Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings

From: kbuild test robot <fengguang.wu@...el.com>
Date: Thu, 23 Feb 2017 20:47:01 +0800

> net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Applied.