netdev - Re: [PATCH net] sctp: set sin_port for addr param when checking duplicate address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170226.212505.1113255842286618172.davem@davemloft.net>
Date:   Sun, 26 Feb 2017 21:25:05 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        marcelo.leitner@...il.com, nhorman@...driver.com,
        vyasevich@...il.com
Subject: Re: [PATCH net] sctp: set sin_port for addr param when checking
 duplicate address

From: Xin Long <lucien.xin@...il.com>
Date: Fri, 24 Feb 2017 15:18:46 +0800

> Commit b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's
> bind address list") tried to check for duplicate address before copying
> to asoc's bind_addr list from global addr list.
> 
> But all the addrs' sin_ports in global addr list are 0 while the addrs'
> sin_ports are bp->port in asoc's bind_addr list. It means even if it's
> a duplicate address, af->cmp_addr will still return 0 as the their
> sin_ports are different.
> 
> This patch is to fix it by setting the sin_port for addr param with
> bp->port before comparing the addrs.
> 
> Fixes: b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's bind address list")
> Reported-by: Wei Chen <weichen@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.