netdev - Re: [PATCH net] ipv6: check sk sk_type and protocol early in ip_mroute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170226.212621.1471488214595328803.davem@davemloft.net>
Date:   Sun, 26 Feb 2017 21:26:21 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com,
        hannes@...essinduktion.org
Subject: Re: [PATCH net] ipv6: check sk sk_type and protocol early in
 ip_mroute_set/getsockopt

From: Xin Long <lucien.xin@...il.com>
Date: Fri, 24 Feb 2017 16:29:06 +0800

> Commit 5e1859fbcc3c ("ipv4: ipmr: various fixes and cleanups") fixed
> the issue for ipv4 ipmr:
> 
>   ip_mroute_setsockopt() & ip_mroute_getsockopt() should not
>   access/set raw_sk(sk)->ipmr_table before making sure the socket
>   is a raw socket, and protocol is IGMP
> 
> The same fix should be done for ipv6 ipmr as well.
> 
> This patch can fix the panic caused by overwriting the same offset
> as ipmr_table as in raw_sk(sk) when accessing other type's socket
> by ip_mroute_setsockopt().
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.