netdev - Re: [PATCH net 1/1] net sched actions: do not overwrite status of action creation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170226.213215.1159999427558211898.davem@davemloft.net>
Date:   Sun, 26 Feb 2017 21:32:15 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mrv@...atatu.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com
Subject: Re: [PATCH net 1/1] net sched actions: do not overwrite status of
 action creation.

From: Roman Mashak <mrv@...atatu.com>
Date: Fri, 24 Feb 2017 17:36:58 -0500

> nla_memdup_cookie was overwriting err value, declared at function
> scope and earlier initialized with result of ->init(). At success
> nla_memdup_cookie() returns 0, and thus module refcnt decremented,
> although the action was installed.
 ...
> Fixes: 1045ba77a ("net sched actions: Add support for user cookies")
> Signed-off-by: Roman Mashak <mrv@...atatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>

Applied, thanks.