[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <E04592A3-747F-4C80-8650-5F1AEE28F92B@holtmann.org>
Date: Thu, 2 Mar 2017 17:50:38 +0100
From: Marcel Holtmann <marcel@...tmann.org>
To: Johannes Berg <johannes@...solutions.net>,
"David S. Miller" <davem@...emloft.net>
Cc: Network Development <netdev@...r.kernel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Removing GENL_ID_GENERATE breaks userspace API
Hi Johannes,
you have removed GENL_ID_GENERATE in 4.10, but that is actually breaking userspace API.
commit a07ea4d9941af5a0c6f0be2a71b51ac9c083c5e5
Author: Johannes Berg <johannes.berg@...el.com>
Date: Mon Oct 24 14:40:02 2016 +0200
genetlink: no longer support using static family IDs
diff --git a/include/uapi/linux/genetlink.h b/include/uapi/linux/genetlink.h
index 5512c90af7e3..d9b2db4a29c6 100644
--- a/include/uapi/linux/genetlink.h
+++ b/include/uapi/linux/genetlink.h
@@ -26,7 +26,6 @@ struct genlmsghdr {
/*
* List of reserved static generic netlink identifiers:
*/
-#define GENL_ID_GENERATE 0
#define GENL_ID_CTRL NLMSG_MIN_TYPE
Since the GENL_ID_GENERATE is in include/uapi/ I would have expected that you leave this in. For us, you just broke userspace API with this change.
Regards
Marcel
Powered by blists - more mailing lists