netdev - Re: [PATCH net-next 7/8] net: stmicro: prepare irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170308.111727.2131799324267281647.davem@davemloft.net>
Date:   Wed, 08 Mar 2017 11:17:27 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Joao.Pinto@...opsys.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 7/8] net: stmicro: prepare irq_status for mtl

From: Joao Pinto <Joao.Pinto@...opsys.com>
Date: Wed,  8 Mar 2017 11:03:14 +0000

> +static int dwmac4_irq_mtl_status(struct mac_device_info *hw, u32 chan)
> +{
> +	void __iomem *ioaddr = hw->pcsr;
> +	u32 mtl_int_qx_status = readl(ioaddr + MTL_INT_STATUS);
> +	int ret = 0;

Please order local variable declarations from longest to shortest
line.