netdev - Re: [PATCH net-next 3/8] net: stmicro: configure tx queue weight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170308.111643.2131946337725707531.davem@davemloft.net>
Date:   Wed, 08 Mar 2017 11:16:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Joao.Pinto@...opsys.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/8] net: stmicro: configure tx queue weight

From: Joao Pinto <Joao.Pinto@...opsys.com>
Date: Wed,  8 Mar 2017 11:03:10 +0000

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index af57f8d..df3b1ee 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1645,6 +1645,23 @@ static void stmmac_init_tx_coalesce(struct stmmac_priv *priv)
>  }
>  
>  /**
> + *  stmmac_set_tx_queue_weight - Set TX queue weight
> + *  @priv: driver private structure
> + *  Description: It is used for setting TX queues weight
> + */
> +static void stmmac_set_tx_queue_weight(struct stmmac_priv *priv)
> +{
> +	u32 tx_queues_count = priv->plat->tx_queues_to_use;
> +	u32 queue = 0;
> +	u32 weight = 0;

Please order local variable declarations from longest to shortest
line.