netdev - Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21773.1489045894@warthog.procyon.org.uk>
Date:   Thu, 09 Mar 2017 07:51:34 +0000
From:   David Howells <dhowells@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     dhowells@...hat.com, netdev@...r.kernel.org,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

David Miller <davem@...emloft.net> wrote:

> I guess this is fine, but I think you can use one of the two "sk_padding"
> bits in struct sock instead of making the structure larger.

It shouldn't make the structure larger since there's a hole in the structure:

		unsigned int		sk_padding : 2,
					sk_no_check_tx : 1,
					sk_no_check_rx : 1,
					sk_userlocks : 4,
					sk_protocol  : 8,
					sk_type      : 16;
	#define SK_PROTOCOL_MAX U8_MAX
		kmemcheck_bitfield_end(flags);

		u16			sk_gso_max_segs;
  ---> 2-byte hole here
		unsigned long	        sk_lingertime;

but I'll quite happily shift it to sk_padding.

Thanks,
David