lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170312203902.GB23127@u480fcf44e5b8574c5490.ant.amazon.com> Date: Sun, 12 Mar 2017 20:39:03 +0000 From: Ezequiel Lara Gomez <ezegomez@...zon.com> To: Richard Cochran <richardcochran@...il.com> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] Enable tx timestamping on loopback and dummy On Sun, Mar 12, 2017 at 05:30:00PM +0100, Richard Cochran wrote: > On Sun, Mar 12, 2017 at 12:17:30AM +0100, Oliver Hartkopp wrote: > > in fact you're doing three different things here: > > > > 1. introduce tx timestamping > > 2. silently change an include: <asm/io.h> -> <linux/io.h> > > 3. fix some whitespace and empty line issues > > > > You'd better provide one patch for 1 & 2 and explain why 2 is needed. > > And while you are at it, explain why #1 is needed. Certainly - 2 (and 3) come from checkpatch.pl suggestions (I'm mostly following through https://kernelnewbies.org/FirstKernelPatch ), so as suggested I've broken them into a separate patch, being styling related only (at least according to that script output). The intent behind 1 is helping developing code that does TX timestamping - I lost a good chunk of time toying with it until I realised 127.0.0.1 could not do TX timestamping because lo did not implement it. > > > Thanks, > Richard > Amazon Data Services Ireland Limited registered office: One Burlington Plaza, Burlington Road, Dublin 4, Ireland. Registered in Ireland. Registration number 390566.
Powered by blists - more mailing lists