netdev - Re: [PATCHv2 1/4] rds: ib: drop unnecessary rdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ad1f78a-f558-7b26-7a31-95cd7507237f@oracle.com>
Date:   Sun, 12 Mar 2017 12:43:42 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Leon Romanovsky <leon@...nel.org>,
        Zhu Yanjun <yanjun.zhu@...cle.com>
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com
Subject: Re: [PATCHv2 1/4] rds: ib: drop unnecessary rdma_reject

On 3/12/17 12:33 PM, Leon Romanovsky wrote:
> On Sun, Mar 12, 2017 at 04:07:55AM -0400, Zhu Yanjun wrote:
>> When rdma_accept fails, rdma_reject is called in it. As such, it is
>> not necessary to execute rdma_reject again.
>>
>> Cc: Joe Jin <joe.jin@...cle.com>
>> Cc: Junxiao Bi <junxiao.bi@...cle.com>
>> Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>
>> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
>> ---
>> Change from v1 to v2:
>>   Add the acker.
>>
>>  net/rds/ib_cm.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
>> index ce3775a..eca3d5f 100644
>> --- a/net/rds/ib_cm.c
>> +++ b/net/rds/ib_cm.c
>> @@ -677,8 +677,7 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
>>  		event->param.conn.initiator_depth);
>>
>>  	/* rdma_accept() calls rdma_reject() internally if it fails */
>> -	err = rdma_accept(cm_id, &conn_param);
>> -	if (err)
>> +	if (rdma_accept(cm_id, &conn_param))
>>  		rds_ib_conn_error(conn, "rdma_accept failed (%d)\n", err);
>
> You omitted initialization of "err" variable which you print here ^^^^^.
>
Its inited by rds_ib_setup_qp() but you are right. It will print
failed with error = 0. :-)

Zhu, please drop that 'err' from the message.