lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <58C5EEF0.4050806@oracle.com> Date: Mon, 13 Mar 2017 08:59:28 +0800 From: Yanjun Zhu <yanjun.zhu@...cle.com> To: "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>, Leon Romanovsky <leon@...nel.org> Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org, rds-devel@....oracle.com Subject: Re: [PATCHv2 1/4] rds: ib: drop unnecessary rdma_reject On 2017/3/13 3:43, santosh.shilimkar@...cle.com wrote: > On 3/12/17 12:33 PM, Leon Romanovsky wrote: >> On Sun, Mar 12, 2017 at 04:07:55AM -0400, Zhu Yanjun wrote: >>> When rdma_accept fails, rdma_reject is called in it. As such, it is >>> not necessary to execute rdma_reject again. >>> >>> Cc: Joe Jin <joe.jin@...cle.com> >>> Cc: Junxiao Bi <junxiao.bi@...cle.com> >>> Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com> >>> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com> >>> --- >>> Change from v1 to v2: >>> Add the acker. >>> >>> net/rds/ib_cm.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c >>> index ce3775a..eca3d5f 100644 >>> --- a/net/rds/ib_cm.c >>> +++ b/net/rds/ib_cm.c >>> @@ -677,8 +677,7 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id >>> *cm_id, >>> event->param.conn.initiator_depth); >>> >>> /* rdma_accept() calls rdma_reject() internally if it fails */ >>> - err = rdma_accept(cm_id, &conn_param); >>> - if (err) >>> + if (rdma_accept(cm_id, &conn_param)) >>> rds_ib_conn_error(conn, "rdma_accept failed (%d)\n", err); >> >> You omitted initialization of "err" variable which you print here ^^^^^. >> > Its inited by rds_ib_setup_qp() but you are right. It will print > failed with error = 0. :-) > > Zhu, please drop that 'err' from the message. OK. I will do. Zhu Yanjun
Powered by blists - more mailing lists