netdev - Re: [PATCH] net: ethernet: aquantia: set net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2017 12:56:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     darcari@...hat.com
Cc:     netdev@...r.kernel.org, Pavel.Belous@...antia.com
Subject: Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu
 is changed

From: David Arcari <darcari@...hat.com>
Date: Mon, 13 Mar 2017 11:50:50 -0400

> On 03/13/2017 02:09 AM, David Miller wrote:
>> From: David Arcari <darcari@...hat.com>
>> Date: Wed,  8 Mar 2017 16:33:21 -0500
>> 
>>> When the aquantia device mtu is changed the net_device structure is not
>>> updated.  As a result the ip command does not properly reflect the mtu change.
>>>
>>> Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
>>> assignment ndev->mtu = new_mtu;  This is not true in the case where the driver
>>> has a ndo_change_mtu routine.
>>>
>>> Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
>>>
>>> Cc: Pavel Belous <Pavel.Belous@...antia.com>
>>> Signed-off-by: David Arcari <darcari@...hat.com>
>> 
>> Applied, thanks.
>> 
> 
> Hi David,
> 
> I see that my patch:
> 
> "net: ethernet: aquantia: call set_irq_affinity_hint before free_irq"
> 
> has been applied to net, but I don't see that this patch has been applied.

It is marked as "changes requested" in patchwork, because you were asked to
do the restart label removal in a separate patch.