netdev - Re: [PATCH net] ipv4: provide stronger user input validation in nl_fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170322.141807.1073258228876112696.davem@davemloft.net>
Date:   Wed, 22 Mar 2017 14:18:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, glider@...gle.com
Subject: Re: [PATCH net] ipv4: provide stronger user input validation in
 nl_fib_input()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 21 Mar 2017 19:22:28 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Alexander reported a KMSAN splat caused by reads of uninitialized
> field (tb_id_in) from user provided struct fib_result_nl
> 
> It turns out nl_fib_input() sanity tests on user input is a bit
> wrong :
> 
> User can pretend nlh->nlmsg_len is big enough, but provide
> at sendmsg() time a too small buffer.
> 
> Reported-by: Alexander Potapenko <glider@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.