netdev - Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170327170019.GR7909@n2100.armlinux.org.uk>
Date:   Mon, 27 Mar 2017 18:00:19 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

On Mon, Mar 27, 2017 at 09:47:31AM -0700, Florian Fainelli wrote:
> On 03/27/2017 02:59 AM, Russell King wrote:
> > As EEE is able to work in SGMII mode as well, add it to the list of
> > permissable EEE modes that phy_init_eee() will accept.  This is
> > necessary so that EEE can work with an 88E1512 connected in SGMII mode.
> 
> As you mention in your cover letter, we should probably reverse this
> test and make it reject modes where EEE has no chance of being supported
> at all.

Want me to re-spin?  Any thought on which interface modes we should
explicitly exclude?

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.