netdev - Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170327170058.GA8441@Red>
Date:   Mon, 27 Mar 2017 19:00:58 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>
Cc:     davem@...emloft.net, peppe.cavallaro@...com,
        alexandre.torgue@...com, thierry.reding@...il.com,
        sergei.shtylyov@...entembedded.com, f.fainelli@...il.com,
        niklas.cassel@...s.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in
 stmmac_poll

On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote:
> Hi David,
> 
> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu:
> > On Fri, Mar 24, 2017 at 05:16:45PM +0000, Joao Pinto wrote:
> >> For cores that have more than 1 TX queue configured, the kernel would crash,
> >> since only one TX queue is permitted by default.
> >>
> >> Signed-off-by: Joao Pinto <jpinto@...opsys.com>
> >> ---
> >>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> >> index 3827952..1eab084 100644
> >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> >> @@ -3429,7 +3429,7 @@ static int stmmac_poll(struct napi_struct *napi, int budget)
> >>  	struct stmmac_rx_queue *rx_q =
> >>  		container_of(napi, struct stmmac_rx_queue, napi);
> >>  	struct stmmac_priv *priv = rx_q->priv_data;
> >> -	u32 tx_count = priv->dma_cap.number_tx_queues;
> >> +	u32 tx_count = priv->plat->tx_queues_to_use;
> >>  	u32 chan = rx_q->queue_index;
> >>  	u32 work_done = 0;
> >>  	u32 queue = 0;
> >> -- 
> >> 2.9.3
> >>
> > 
> > This patch fix the performance issue on dwmac-sun8i only.
> > The dwmac-sunxi is still broken.
> > 
> 
> This patch series can be upstreamed please, since they make 2 fixes, one of them
> solving the problem in dwmac-sun8i.
> 
> Thanks.

As I said in a previous answer, finaly dwmac-sun8i is still broken.
Adding thoses 2 patch will just made the revert harder.

Regards