netdev - Re: [PATCH nf-next 1/1] net: tcp: Refine the __tcp_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170330.154210.2218850010642353664.davem@davemloft.net>
Date:   Thu, 30 Mar 2017 15:42:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gfree.wind@...mail.com
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, netdev@...r.kernel.org,
        fgao@...ai8.com
Subject: Re: [PATCH nf-next 1/1] net: tcp: Refine the __tcp_select_window

From: gfree.wind@...mail.com
Date: Thu, 30 Mar 2017 06:49:19 +0800

> From: Gao Feng <fgao@...ai8.com>
> 
> 1. Move the "window = tp->rcv_wnd;" into the condition block without
> tp->rx_opt.rcv_wscale.
> Because it is unnecessary when enable wscale;
> 
> 2. Use the macro ALIGN instead of two statements.
> The two statements are used to make window align to 1<<wscale.
> Use the ALIGN is more clearer.
> 
> 3. Use the rounddown to make codes clearer.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>

Applied, but please do not target non-netfilter patches using
"nf-next" in your Subject lines.