netdev - Re: [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XfMNWG1=X79=XySTu4C4iqWGU+ytgt7z3R+RRb3mEVX8A@mail.gmail.com>
Date:   Fri, 31 Mar 2017 09:18:57 +1030
From:   Joel Stanley <joel@....id.au>
To:     Mark Brown <broonie@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Gavin Shan <gwshan@...ux.vnet.ibm.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h

On Fri, Mar 31, 2017 at 2:30 AM, Mark Brown <broonie@...nel.org> wrote:
> This driver uses interfaces from linux/of.h and linux/property.h but
> relies on implict inclusion of those headers which means that changes in
> other headers could break the build, as happened in -next for arm today.
> Add a explicit includes.
>
> Signed-off-by: Mark Brown <broonie@...nel.org>

Acked-by: Joel Stanley <joel@....id.au>

Thank you for fixing this Mark.

Cheers,

Joel

> ---
>  drivers/net/ethernet/faraday/ftgmac100.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 928b0df2b8e0..ade6b3e4ed13 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -28,8 +28,10 @@
>  #include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/netdevice.h>
> +#include <linux/of.h>
>  #include <linux/phy.h>
>  #include <linux/platform_device.h>
> +#include <linux/property.h>
>  #include <net/ip.h>
>  #include <net/ncsi.h>
>
> --
> 2.11.0
>