netdev - Re: [PATCH 5/5] PCI: remove pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170330225610.GA2496@bhelgaas-glaptop.roam.corp.google.com>
Date:   Thu, 30 Mar 2017 17:56:11 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     David Daney <ddaney.cavm@...il.com>
Cc:     Christoph Hellwig <hch@....de>, bhelgaas@...gle.com,
        davem@...emloft.net, netanel@...apurnalabs.com, jcliburn@...il.com,
        chris.snook@...il.com, sgoutham@...ium.com, rric@...nel.org,
        netdev@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 5/5] PCI: remove pci_enable_msix

On Tue, Mar 28, 2017 at 09:24:15AM -0700, David Daney wrote:
> On 03/27/2017 11:41 PM, Christoph Hellwig wrote:
> >On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote:
> >>>Use pci_enable_msix_{exact,range} for now, as I told you before.
> >>>
> >>
> >>That still results in twice as many MSI-X being provisioned than are needed.
> >
> >How so?  Except for the return value, a pci_enable_msix_exact call with the
> >same arguments as your previous pci_enable_msix will work exactly the
> >same.
> >
> 
> Sorry, I think it was my misunderstanding.  I didn't realize that we
> had essentially renamed the function, but left the functionality
> mostly unchanged.

Does this mean you're OK with this patch?  I know it may require some
work on out-of-tree drivers and so on, but if that work is possible
and you don't actually lose functionality, I'm OK with this patch.

Bjorn