netdev - Re: [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <819bc6c1-581b-3ab9-d189-1befaaf43548@huawei.com>
Date:   Sun, 2 Apr 2017 14:49:47 +0800
From:   Ding Tianhong <dingtianhong@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <catalin.marinas@....com>, <will.deacon@....com>,
        <mark.rutland@....com>, <robin.murphy@....com>,
        <jeffrey.t.kirsher@...el.com>, <alexander.duyck@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH net-next 1/4] ixgbe: sparc: rename the
 ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER



On 2017/4/2 2:26, David Miller wrote:
> From: Ding Tianhong <dingtianhong@...wei.com>
> Date: Sat, 1 Apr 2017 15:25:51 +0800
> 
>> Till now only the Intel ixgbe could support enable
>> Relaxed ordering in the drivers for special architecture,
>> but the ARCH_WANT_RELAX_ORDER is looks like a general name
>> for all arch, so rename to a specific name for intel
>> card looks more appropriate.
>>
>> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> 
> This is not a driver specific facility.
> 
> Any driver can test this symbol and act accordingly.
> 
> Just because IXGBE is the first and only user, doesn't mean
> the facility is driver specific.
> 

Understand clearly，but the ARCH_WANT_RELAX_ORDER is really too generic and simple,
cause much misleading to indicate that it looks like the hack code for some architecture.
what do you think of the ETHERNET_ALLOW_RELAXED_ORDER in the drivers/net/ethernet/*,
it will only affect ethernet and not only for Ixgbe.

Thanks
Ding


> Thank you.
> 
> .
>