netdev - RE: [PATCH net-next] liquidio: use meaningful names for IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY1PR07MB2665225225D98B5366576AA3EC080@CY1PR07MB2665.namprd07.prod.outlook.com>
Date:   Mon, 3 Apr 2017 15:03:31 +0000
From:   Ricardo Farrington <Ricardo.Farrington@...ium.com>
To:     Sunil Kovvuri <sunil.kovvuri@...il.com>,
        "Manlunas, Felix" <Felix.Manlunas@...ium.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        "Vatsavayi, Raghu" <Raghu.Vatsavayi@...ium.com>,
        "Chickles, Derek" <Derek.Chickles@...ium.com>,
        "Burla, Satananda" <Satananda.Burla@...ium.com>
Subject: RE: [PATCH net-next] liquidio: use meaningful names for IRQs

Hi Sunil - this implementation was verified with multiple adapters installed.  In this case, the <id> field serves to differentiate the adapter.

>     LiquidIO<id>-<func>-<type>-<queue pair num>

Rick


-----Original Message-----
From: Sunil Kovvuri [mailto:sunil.kovvuri@...il.com] 
Sent: Monday, April 03, 2017 2:56 AM
To: Manlunas, Felix <Felix.Manlunas@...ium.com>
Cc: David S. Miller <davem@...emloft.net>; Linux Netdev List <netdev@...r.kernel.org>; Vatsavayi, Raghu <Raghu.Vatsavayi@...ium.com>; Chickles, Derek <Derek.Chickles@...ium.com>; Burla, Satananda <Satananda.Burla@...ium.com>; Ricardo Farrington <Ricardo.Farrington@...ium.com>
Subject: Re: [PATCH net-next] liquidio: use meaningful names for IRQs

On Tue, Mar 14, 2017 at 1:28 AM, Felix Manlunas <felix.manlunas@...ium.com> wrote:
> From: Rick Farrington <ricardo.farrington@...ium.com>
>
> All IRQs owned by the PF and VF drivers share the same nondescript 
> name "octeon"; this makes it difficult to setup interrupt affinity.
>
> Change the IRQ names to reflect their specific purpose:
>
>     LiquidIO<id>-<func>-<type>-<queue pair num>
>
> Examples:
>     LiquidIO0-pf0-rxtx-3
>     LiquidIO1-vf1-rxtx-0
>     LiquidIO0-pf0-aux

Probably too late, but just my 2 cents.

If there are multiple LiquidIO cards connected in a system, wouldn't the same issue of how to setup IRQ affinities arise ?
How do you map netdev->name to IRQ name ?

>
> We cannot use netdev->name for naming the IRQs because:
>
>     1.  Early during init, the PF and VF drivers require interrupts to
>         send/receive control data from the NIC firmware; so the PF and VF
>         must request IRQs long before the netdev struct is registered.
>
>     2.  The IRQ name can only be specified at the time it is requested.
>         It cannot be changed after that.

You can try splitting IRQ registration and register IRQs for sending/receiving control data with above naming but for queues, IRQs can be registered after netdev struct is registered.

Thanks,
Sunil.