netdev - Re: [PATCH net-next] liquidio: use meaningful names for IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+sq2CdG9fBR-Hw3rULMJON3aFQkCXtEpgkfKTzYhd5s=Lo1Tw@mail.gmail.com>
Date:   Mon, 3 Apr 2017 15:25:48 +0530
From:   Sunil Kovvuri <sunil.kovvuri@...il.com>
To:     Felix Manlunas <felix.manlunas@...ium.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        "Vatsavayi, Raghu" <raghu.vatsavayi@...ium.com>,
        "Chickles, Derek" <derek.chickles@...ium.com>,
        satananda.burla@...ium.com, ricardo.farrington@...ium.com
Subject: Re: [PATCH net-next] liquidio: use meaningful names for IRQs

On Tue, Mar 14, 2017 at 1:28 AM, Felix Manlunas
<felix.manlunas@...ium.com> wrote:
> From: Rick Farrington <ricardo.farrington@...ium.com>
>
> All IRQs owned by the PF and VF drivers share the same nondescript name
> "octeon"; this makes it difficult to setup interrupt affinity.
>
> Change the IRQ names to reflect their specific purpose:
>
>     LiquidIO<id>-<func>-<type>-<queue pair num>
>
> Examples:
>     LiquidIO0-pf0-rxtx-3
>     LiquidIO1-vf1-rxtx-0
>     LiquidIO0-pf0-aux

Probably too late, but just my 2 cents.

If there are multiple LiquidIO cards connected in a system, wouldn't the same
issue of how to setup IRQ affinities arise ?
How do you map netdev->name to IRQ name ?

>
> We cannot use netdev->name for naming the IRQs because:
>
>     1.  Early during init, the PF and VF drivers require interrupts to
>         send/receive control data from the NIC firmware; so the PF and VF
>         must request IRQs long before the netdev struct is registered.
>
>     2.  The IRQ name can only be specified at the time it is requested.
>         It cannot be changed after that.

You can try splitting IRQ registration and register IRQs for sending/receiving
control data with above naming but for queues, IRQs can be registered after
netdev struct is registered.

Thanks,
Sunil.