netdev - Re: [PATCH net] sctp: listen on the sock only when it's state is listening or closed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170406130219.GF911@localhost.localdomain>
Date:   Thu, 6 Apr 2017 10:02:19 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem@...emloft.net, Neil Horman <nhorman@...driver.com>,
        andreyknvl@...gle.com
Subject: Re: [PATCH net] sctp: listen on the sock only when it's state is
 listening or closed

On Thu, Apr 06, 2017 at 01:10:52PM +0800, Xin Long wrote:
> Now sctp doesn't check sock's state before listening on it. It could
> even cause changing a sock with any state to become a listening sock
> when doing sctp_listen.
> 
> This patch is to fix it by checking sock's state in sctp_listen, so
> that it will listen on the sock with right state.
> 
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
> Tested-by: Andrey Konovalov <andreyknvl@...gle.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Dave, please consider this for -stable. Thanks

> ---
>  net/sctp/socket.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index c1401f4..d9d4c92 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -7034,6 +7034,9 @@ int sctp_inet_listen(struct socket *sock, int backlog)
>  	if (sock->state != SS_UNCONNECTED)
>  		goto out;
>  
> +	if (!sctp_sstate(sk, LISTENING) && !sctp_sstate(sk, CLOSED))
> +		goto out;
> +
>  	/* If backlog is zero, disable listening. */
>  	if (!backlog) {
>  		if (sctp_sstate(sk, CLOSED))
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>