netdev - Re: [PATCH net-next 0/2] New getsockopt option to retrieve socket cookie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170406130552.GA58484@ast-mbp.thefacebook.com>
Date:   Thu, 6 Apr 2017 09:05:53 -0400
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Chenbo Feng <chenbofeng.kernel@...il.com>
Cc:     netdev@...r.kernel.org, Lorenzo Colitti <lorenzo@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Chenbo Feng <fengc@...gle.com>
Subject: Re: [PATCH net-next 0/2] New getsockopt option to retrieve socket
 cookie

On Wed, Apr 05, 2017 at 07:00:54PM -0700, Chenbo Feng wrote:
> From: Chenbo Feng <fengc@...gle.com>
> 
> 
> In the current kernel socket cookie implementation, there is no simple
> and direct way to retrieve the socket cookie based on file descriptor. A
> process mat need to get it from sock fd if it want to correlate with
> sock_diag output or use a bpf map with new socket cookie function.
> 
> If userspace wants to receive the socket cookie for a given socket fd,
> it must send a SOCK_DIAG_BY_FAMILY dump request and look for the 5-tuple.
> This is slow and can be ambiguous in the case of sockets that have the
> same 5-tuple (e.g., tproxy / transparent sockets, SO_REUSEPORT sockets,
> etc.).
> 
> As shown in the example program. The xt_eBPF program is using socket cookie
> to record the network traffics statistics and with the socket cookie
> retrieved by getsockopt. The program can directly access to a specific
> socket data without scanning the whole bpf map.

Thank you for detailed description of the feature.
Both patches look good to me.
Acked-by: Alexei Starovoitov <ast@...nel.org>