netdev - Re: [PATCH net] team: call netdev_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170406132458.GB2064@nanopsycho>
Date:   Thu, 6 Apr 2017 15:24:58 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net
Subject: Re: [PATCH net] team: call netdev_change_features out of team lock

Thu, Apr 06, 2017 at 07:41:28AM CEST, lucien.xin@...il.com wrote:
>Commit f6988cb63a4e ("team: don't call netdev_change_features under
>team->lock") fixed the issue calling netdev_change_features under
>team->lock for team_compute_features.
>
>But there are still two places where it calls netdev_change_features
>under team->lock, team_port_add and team_port_del. It may cause a
>dead lock when the slave port with LRO enabled is added.
>
>This patch is to fix this dead lock by moving netdev_change_features
>out of team_port_add and team_port_del, and call it after unlocking
>the team lock.
>
>Reported-by: Patrick Talbert <ptalbert@...hat.com>
>Signed-off-by: Xin Long <lucien.xin@...il.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>