netdev - Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1704091025350.18194@n3.vanv.qr>
Date:   Sun, 9 Apr 2017 10:26:41 +0200 (CEST)
From:   Jan Engelhardt <jengelh@...i.de>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        "David S. Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: netfilter: Replace explicit NULL comparisons


On Sunday 2017-04-09 05:42, Arushi Singhal wrote:
>On Sun, Apr 9, 2017 at 1:44 AM, Pablo Neira Ayuso <pablo@...filter.org> wrote:
>      On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote:
>      > On Saturday 2017-04-08 19:21, Arushi Singhal wrote:
>      >
>      > >Replace explicit NULL comparison with ! operator to simplify code.
>      >
>      > I still wouldn't do this, for the same reason as before. Comparing to
>      > NULL explicitly more or less gave an extra guarantee that the other
>      > operand was also a pointer.
>
>      Arushi, where does it say in the coding style that this is prefered? 
>
>This is reported by checkpatch.pl script.

checkpatch has been controversial at times, like when people took the 80
character limit way too literally. Changing pointer comparisons looks like
another thing that is better left ignored.