netdev - Re: [PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1206383-7fad-55ca-0717-5e485b9bee92@redhat.com>
Date:   Sun, 9 Apr 2017 11:35:53 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        netdev@...r.kernel.org, russianneuromancer@...ru
Subject: Re: [PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID

Hi,

On 09-04-17 10:01, Marcel Holtmann wrote:
> Hi Hans,
>
>> The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets
>> for bluetooth rfkill functionality.
>>
>> Tested-by: russianneuromancer@...ru <russianneuromancer@...ru>
>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
>> ---
>> net/rfkill/rfkill-gpio.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
>> index 76c01cb..50ca65e 100644
>> --- a/net/rfkill/rfkill-gpio.c
>> +++ b/net/rfkill/rfkill-gpio.c
>> @@ -163,6 +163,7 @@ static int rfkill_gpio_remove(struct platform_device *pdev)
>> static const struct acpi_device_id rfkill_acpi_match[] = {
>> 	{ "BCM4752", RFKILL_TYPE_GPS },
>> 	{ "LNV4752", RFKILL_TYPE_GPS },
>> +	{ "OBDA8723", RFKILL_TYPE_BLUETOOTH },
>> 	{ },
>> };
>
> NAK. We are integrating these with hci_bcm.c or hci_intel.c drivers.

This is for the bluetooth side of the rtl8723bs driver which recently
(yesterday) got merged in into drivers/staging. Which still needs
hciattach from userspace. I completely agree that eventually we should
fix that. In the mean time it would be nice if we could carry this
one line patch to give people using the staging driver working bluetooth.

Regards,

Hans