netdev - Re: [PATCH] smsc95xx: Add comments to the registers definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170410135251.GC19820@lunn.ch>
Date:   Mon, 10 Apr 2017 15:52:51 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Martin Wetterwald <martin@...terwald.eu>
Cc:     davem@...emloft.org,
        Steve Glendinning <steve.glendinning@...well.net>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] smsc95xx: Add comments to the registers definition

Hi Martin

> @@ -2032,7 +2032,7 @@ static struct sk_buff *smsc95xx_tx_fixup(struct usbnet *dev,
>  	skb_push(skb, 4);
>  	tx_cmd_b = (u32)(skb->len - 4);
>  	if (csum)
> -		tx_cmd_b |= TX_CMD_B_CSUM_ENABLE;
> +		tx_cmd_b |= TX_CMD_B_CSUM_EN;

This changed seems a step backwards, ENABLE is much more readable than EN.

>  
> -#define TX_CMD_B_CSUM_ENABLE		(0x00004000)
> -#define TX_CMD_B_ADD_CRC_DISABLE_	(0x00002000)
> -#define TX_CMD_B_DISABLE_PADDING_	(0x00001000)
> -#define TX_CMD_B_PKT_BYTE_LENGTH_	(0x000007FF)
> +#define TX_CMD_B_CSUM_EN	(0x00004000)	/* TX Checksum Enable */

And there is space for ABLE here.

    Andrew