netdev - Re: [PATCH] p54: add null pointer check before releasing socket buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170410.070337.626219013449399798.davem@davemloft.net>
Date:   Mon, 10 Apr 2017 07:03:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mhjungk@...il.com
Cc:     chunkeey@...glemail.com, netdev@...r.kernel.org
Subject: Re: [PATCH] p54: add null pointer check before releasing socket
 buffer

From: Myungho Jung <mhjungk@...il.com>
Date: Sun,  9 Apr 2017 22:23:20 -0700

> Kernel panic is caused by trying to dereference null pointer. Check if
> the pointer is null before freeing space.
> 
> Signed-off-by: Myungho Jung <mhjungk@...il.com>

Your tests are backwards, you therefore did not test your change.
In fact, your change is adding a memory leak.

It also calls into question whether there is a problem in the
first place.  What "panic" or crash did you actually see?