netdev - Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170411.200347.823503315758200310.davem@davemloft.net>
Date:   Tue, 11 Apr 2017 20:03:47 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     benh@...nel.crashing.org
Cc:     sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org
Subject: Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Date: Wed, 12 Apr 2017 09:36:05 +1000

> I should call the helper when I don't recognize the protocol type in
> the IP header, not just when the main skb protocol type is not IP.

That's correct.

> BTW. I'm not too familiar with how encapsulation works these days. I
> wouldn't throw at that HW anything other than unencapsulated packets
> for HW checksumming. Is checking skb->protocol to be IP and
> ip_hdr(skb)->protocol to be IP, UDP or TCP enough ? IE. Will the latter
> especially return the outer header ?

If skb->protocol is IP then yes ip_hdr() will point at the outermost
header.