netdev - Re: [PATCH v3 2/3] VSOCK: Add vsockmon device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170412.130510.1661492983569723913.davem@davemloft.net>
Date:   Wed, 12 Apr 2017 13:05:10 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mst@...hat.com
Cc:     stefanha@...hat.com, netdev@...r.kernel.org, zyjzyj2000@...il.com,
        ggarcia@...a.uab.cat, jhansen@...are.com
Subject: Re: [PATCH v3 2/3] VSOCK: Add vsockmon device

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Wed, 12 Apr 2017 19:43:20 +0300

> On Wed, Apr 12, 2017 at 05:08:24PM +0100, Stefan Hajnoczi wrote:
>> +struct af_vsockmon_hdr {
>> +	__le64 src_cid;
>> +	__le64 dst_cid;
>> +	__le32 src_port;
>> +	__le32 dst_port;
>> +	__le16 op;			/* enum af_vsockmon_op */
>> +	__le16 transport;		/* enum af_vsockmon_transport */
>> +	__le16 len;			/* Transport header length */
>> +} __attribute__((packed));
> 
> I'd add a 2 byte padding here and then you do not need to pack it.

Indeed, use of the packed attribute is strongly discouraged.