netdev - Re: [PATCH v3 1/3] VSOCK: Add vsockmon tap functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170413150133.GG13387@stefanha-x1.localdomain>
Date:   Thu, 13 Apr 2017 16:01:33 +0100
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     netdev@...r.kernel.org, Zhu Yanjun <zyjzyj2000@...il.com>,
        Gerard Garcia <ggarcia@...a.uab.cat>,
        Jorgen Hansen <jhansen@...are.com>
Subject: Re: [PATCH v3 1/3] VSOCK: Add vsockmon tap functions

On Wed, Apr 12, 2017 at 07:37:36PM +0300, Michael S. Tsirkin wrote:
> On Wed, Apr 12, 2017 at 05:08:23PM +0100, Stefan Hajnoczi wrote:
> > +int __vsock_remove_tap(struct vsock_tap *vt) {
> > +	bool found = false;
> > +	struct vsock_tap *tmp;
> > +
> > +	spin_lock(&vsock_tap_lock);
> > +
> > +	list_for_each_entry(tmp, &vsock_tap_all, list) {
> > +		if (vt == tmp) {
> > +			list_del_rcu(&vt->list);
> > +			found = true;
> > +			goto out;
> > +		}
> > +	}
> > +
> > +	pr_warn("__vsock_remove_tap: %p not found\n", vt);
> > +out:
> > +	spin_unlock(&vsock_tap_lock);
> > +
> > +	if (found)
> > +		module_put(vt->module);
> 
> This is called before synchronize_net so there might
> still be users for this tap.

Thanks, will fix.

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)