netdev - Re: [PATCH v3 2/3] VSOCK: Add vsockmon device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170413150213.GH13387@stefanha-x1.localdomain>
Date:   Thu, 13 Apr 2017 16:02:13 +0100
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     mst@...hat.com, netdev@...r.kernel.org, zyjzyj2000@...il.com,
        ggarcia@...a.uab.cat, jhansen@...are.com
Subject: Re: [PATCH v3 2/3] VSOCK: Add vsockmon device

On Wed, Apr 12, 2017 at 01:05:10PM -0400, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@...hat.com>
> Date: Wed, 12 Apr 2017 19:43:20 +0300
> 
> > On Wed, Apr 12, 2017 at 05:08:24PM +0100, Stefan Hajnoczi wrote:
> >> +struct af_vsockmon_hdr {
> >> +	__le64 src_cid;
> >> +	__le64 dst_cid;
> >> +	__le32 src_port;
> >> +	__le32 dst_port;
> >> +	__le16 op;			/* enum af_vsockmon_op */
> >> +	__le16 transport;		/* enum af_vsockmon_transport */
> >> +	__le16 len;			/* Transport header length */
> >> +} __attribute__((packed));
> > 
> > I'd add a 2 byte padding here and then you do not need to pack it.
> 
> Indeed, use of the packed attribute is strongly discouraged.

Thanks will fix.

Stefan

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)