netdev - Re: [RFC PATCH 0/7] Extend socket timestamping API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170413095354.GA7490@localhost>
Date:   Thu, 13 Apr 2017 11:53:54 +0200
From:   Miroslav Lichvar <mlichvar@...hat.com>
To:     "Keller, Jacob E" <jacob.e.keller@...el.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Richard Cochran <richardcochran@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Denny Page <dennypage@...com>, Jiri Benc <jbenc@...hat.com>
Subject: Re: [RFC PATCH 0/7] Extend socket timestamping API

On Thu, Apr 13, 2017 at 09:08:08AM +0000, Keller, Jacob E wrote:
> > -----Original Message-----
> > This patchset adds new options to the timestamping API that will be
> > useful for NTP implementations and possibly other applications.

> I think this looks pretty good, straight forward and useful. I agree with Richard about the one commit message, but the rest looks good modulo missing updates for all the other drivers.

Thanks for the review.

> I didn't see any code to update the ethtool get_ts_info data for _NTP_ALL either.

My understanding was that ethtool should list only filters that are
actually supported by the HW and are not handled just by switching to
a more general filter. I think that's what drivers I've looked were
doing. The phyter driver would be the only one that could list the
filter as supported. Is that correct?

-- 
Miroslav Lichvar