netdev - RE: [RFC PATCH 0/7] Extend socket timestamping API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB5857E00EB6@ORSMSX115.amr.corp.intel.com>
Date:   Thu, 13 Apr 2017 09:08:08 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Miroslav Lichvar <mlichvar@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Richard Cochran <richardcochran@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Denny Page <dennypage@...com>, Jiri Benc <jbenc@...hat.com>
Subject: RE: [RFC PATCH 0/7] Extend socket timestamping API

> -----Original Message-----
> From: Miroslav Lichvar [mailto:mlichvar@...hat.com]
> Sent: Wednesday, April 12, 2017 7:18 AM
> To: netdev@...r.kernel.org
> Cc: Richard Cochran <richardcochran@...il.com>; Willem de Bruijn
> <willemb@...gle.com>; Soheil Hassas Yeganeh <soheil@...gle.com>; Keller,
> Jacob E <jacob.e.keller@...el.com>; Denny Page <dennypage@...com>; Jiri
> Benc <jbenc@...hat.com>
> Subject: [RFC PATCH 0/7] Extend socket timestamping API
> 
> This patchset adds new options to the timestamping API that will be
> useful for NTP implementations and possibly other applications.
> 
> The first patch specifies a timestamp filter for NTP packets, which is
> handled in the second patch in drivers that can timestamp all packets.
> There is no attempt to add the support to the phyter driver.
> 
> The third patch adds a new option to get information about
> HW-timestamped packets. The fourth patch adds support for this option to
> the drivers (currently only igb and e1000e).
> 
> The fifth patch fixes the code to not make a false software TX timestamp
> when HW timestamping is enabled. The sixth patch depends on this fix.
> 
> The sixth patch adds a new option to allow outgoing packets to be looped
> multiple times to the error queue in order to allow simultaneous SW and
> HW timestamping. The seventh patch updates drivers that assumed SW
> timestamping cannot be used together with HW timestamping.
> 

I think this looks pretty good, straight forward and useful. I agree with Richard about the one commit message, but the rest looks good modulo missing updates for all the other drivers.

I didn't see any code to update the ethtool get_ts_info data for _NTP_ALL either.

Thanks,
Jake