netdev - RE: [RFC PATCH 4/7] net: ethernet: update drivers to provide timestamping packet info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Apr 2017 09:04:21 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Miroslav Lichvar <mlichvar@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Richard Cochran <richardcochran@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Denny Page <dennypage@...com>, Jiri Benc <jbenc@...hat.com>
Subject: RE: [RFC PATCH 4/7] net: ethernet: update drivers to provide
 timestamping packet info

> -----Original Message-----
> From: Miroslav Lichvar [mailto:mlichvar@...hat.com]
> Sent: Wednesday, April 12, 2017 7:18 AM
> To: netdev@...r.kernel.org
> Cc: Richard Cochran <richardcochran@...il.com>; Willem de Bruijn
> <willemb@...gle.com>; Soheil Hassas Yeganeh <soheil@...gle.com>; Keller,
> Jacob E <jacob.e.keller@...el.com>; Denny Page <dennypage@...com>; Jiri
> Benc <jbenc@...hat.com>
> Subject: [RFC PATCH 4/7] net: ethernet: update drivers to provide timestamping
> packet info
> 
> Update drivers that support hardware timestamping to provide the
> interface index and packet length for the SOF_TIMESTAMPING_OPT_PKTINFO
> option.
> 
> TODO: update other drivers (not just e1000e and igb)
> 
> CC: Richard Cochran <richardcochran@...il.com>
> CC: Willem de Bruijn <willemb@...gle.com>
> CC: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Miroslav Lichvar <mlichvar@...hat.com>
> ---

Driver changes seem alright to me. I might have gone a different route without changing the return value of functions but it doesn't make a huge difference, and i guess this route is easier to follow the code.

Thanks,
Jake