netdev - RE: [RFC PATCH 2/7] net: ethernet: update drivers to handle HWTSTAMP_FILTER_NTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB5857E00E6E@ORSMSX115.amr.corp.intel.com>
Date:   Thu, 13 Apr 2017 09:00:01 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Miroslav Lichvar <mlichvar@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Richard Cochran <richardcochran@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Denny Page <dennypage@...com>, Jiri Benc <jbenc@...hat.com>
Subject: RE: [RFC PATCH 2/7] net: ethernet: update drivers to handle
 HWTSTAMP_FILTER_NTP_ALL



> -----Original Message-----
> From: Miroslav Lichvar [mailto:mlichvar@...hat.com]
> Sent: Wednesday, April 12, 2017 7:18 AM
> To: netdev@...r.kernel.org
> Cc: Richard Cochran <richardcochran@...il.com>; Willem de Bruijn
> <willemb@...gle.com>; Soheil Hassas Yeganeh <soheil@...gle.com>; Keller,
> Jacob E <jacob.e.keller@...el.com>; Denny Page <dennypage@...com>; Jiri
> Benc <jbenc@...hat.com>
> Subject: [RFC PATCH 2/7] net: ethernet: update drivers to handle
> HWTSTAMP_FILTER_NTP_ALL
> 
> Update drivers which can timestamp all packets to handle also
> HWTSTAMP_FILTER_NTP_ALL.
> 

The code looks ok to me, though I agree with Richard that the description should be more clear that not all locations are about supporting the new feature (since many locations don't actually support ALL but merely error out)

Thanks,
Jake