netdev - Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5da86d13-0e61-8282-614e-b8ade10c75e6@mojatatu.com>
Date:   Sat, 15 Apr 2017 10:12:29 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        Wolfgang Bumiller <w.bumiller@...xmox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized
 data and error handling

On 17-04-12 09:22 PM, Cong Wang wrote:
> On Wed, Apr 12, 2017 at 7:21 AM, Wolfgang Bumiller
> <w.bumiller@...xmox.com> wrote:
>> Commit 1045ba77a ("net sched actions: Add support for user cookies")
>> added code to net/sched/act_api.c's tcf_action_init_1 using the `tb`
>> nlattr array unconditionally, while it was otherwise used as well as
>> initialized only when `name == NULL`:
>>
>>         if (name == NULL) {
>>                 err = nla_parse_nested(tb, TCA_ACT_MAX, nla, NULL);
>>
>> In the other case `nla` is instead passed over to ->init to be parsed
>> there (using a different set of TCA_ enum values, iow. TCA_ACT_COOKIE
>> then "clashes" with some other value). This lead to the following three
>> example commands resulting in errors (sometimes followed by more traces
>> and hangups some time later (although the hangups happened seconds or
>> sometimes minutes later, sometimes not at all - results differed between
>> different kernel versions (linux git-master vs ubuntu's mainline 4.11
>> rc6 vs. pve 4.10.5 (based off ubuntu's zesty kernel where the commit is
>> cherry-picked)...))):
>
>
> Makes sense.
>
>>
>>  # ip link add ve0 type veth peer name ve0b
>>  # tc qdisc add dev ve0 handle ffff: ingress
>>  # tc filter add dev ve0 parent ffff: prio 50 basic police rate 1000bps burst 1000b drop
>>
>> The 3rd command would sometimes succeed, sometimes error with:
>>
>>  RTNETLINK answers: Invalid argument
>>  We have an error talking to the kernel
>>
>> and sometimes error with:
>>
>>  RTNETLINK answers: Cannot allocate memory
>>  We have an error talking to the kernel
>>
>> In the latter case I assume `cklen` became negative, which passes the
>> TC_COOKIE_MAX_SIZE check since it is signed but becomes unsigned later
>> in kmemdup() (see the crash dump below)
>
>
> Yeah because tb[] contains some random pointers when not initialized.
>
>>
>> When the `tc filter add` command fails a backtrace shows up in dmesg,
>> added below.
>>
>> I'm not sure why the TC_ACT_COOKIE code was added to tcf_action_init_1
>> where it is now. It makes me think that it's supposed to be available
>> universally, but the `name == NULL` check for how nla is used or passed
>> to ->init() shows that the there are various different TC_ACT_* enums in
>> use at this point, hence the 'RFC' part of the patches, I'm not that
>> familiar with the code yet.
>>
>
> According to commit 1045ba77a5962a22bce777767, it is generic,
> but if we need it for act_police too, we should add it to TCA_POLICE*.
>
> Thanks.
>


Sorry - didnt get the full thread (the OP managed to post to CC
linux kernel list but not me); trying to catch up.

So the issue if i understood:
Policer was created but failed and we the error code mistakenly
did a hash_release?

I do observe an issue if the above was to happen. I think we need
two variables instead of one.
Will dig through the list.

cheers,
jamal
cheers,
jamal