netdev - Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08ae66eb-5629-f5d9-f951-2510f041028f@mojatatu.com>
Date:   Sat, 15 Apr 2017 12:51:24 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        Wolfgang Bumiller <w.bumiller@...xmox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Roman Mashak <mrv@...atatu.com>
Subject: Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized
 data and error handling

On 17-04-15 10:12 AM, Jamal Hadi Salim wrote:
> On 17-04-12 09:22 PM, Cong Wang wrote:

> Sorry - didnt get the full thread (the OP managed to post to CC
> linux kernel list but not me); trying to catch up.
>
> So the issue if i understood:
> Policer was created but failed and we the error code mistakenly
> did a hash_release?
>
> I do observe an issue if the above was to happen. I think we need
> two variables instead of one.
> Will dig through the list.


I found them. The patches look sane.

Please resend v2 (the second version of patch 2 where you moved
module check up) and add my Acked-by.
Also - please dont cross post to linux kernel list (and Cc me).

I think Roman has  slightly different use case but
he triggers a related issue your patch seems to address.

cheers,
jamal