netdev - Re: [PATCH] net/ncsi: fix checksum validation in response packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170417.133619.1515025171498720534.davem@davemloft.net>
Date:   Mon, 17 Apr 2017 13:36:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     clg@...d.org
Cc:     gwshan@...ux.vnet.ibm.com, joel@....id.au, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ncsi: fix checksum validation in response packet

From: Cédric Le Goater <clg@...d.org>
Date: Fri, 14 Apr 2017 10:56:37 +0200

> htonl was used instead of ntohl. Surely a typo.
> 
> Signed-off-by: Cédric Le Goater <clg@...d.org>

I don't think so, "checksum" is of type "u32" thus is in host byte
order.  Therefore "htonl()" is correct.